[wp-trac] [WordPress Trac] #59965: Reply link: Elements with visible text labels do not have matching accessible names

[WordPress Trac]

#59965: Reply link: Elements with visible text labels do not have matching
accessible names
------------------------------+--------------------------------------
 Reporter:  halilesen         |       Owner:  (none)
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  6.7
Component:  Comments          |     Version:  4.1
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:  accessibility, template
------------------------------+--------------------------------------
Changes (by joedolson):

 * keywords:  has-patch => has-patch commit


Comment:

 This is a good approach; rather than trying to magically change the `aria-
 label` value based on what the author passes into the function, it allows
 authors to set that value. While this has the weakness that an author is
 able to define an `aria-label` value that violates WCAG's label in name
 rule, anything that tried to construct a string using the existing
 `reply_text` value would have had significant translation problems.

 I also like that this makes it possible to have a visible text using the
 current ARIA value, which is a significant accessibility benefit.

 I'm extending the code comment on `reply_to_text` slightly to provide
 guidance relevant to WCAG 2.5.3, but otherwise I think this is good to go.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59965#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform