[wp-trac] [WordPress Trac] #62166: Bundled themes: PHPCS "exactly one blank line after the file comment"
WordPress Trac
noreply at wordpress.org
Fri Oct 4 22:36:51 UTC 2024
#62166: Bundled themes: PHPCS "exactly one blank line after the file comment"
---------------------------+-------------------------------
Reporter: dhruvang21 | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Bundled Theme | Version:
Severity: minor | Resolution:
Keywords: has-patch | Focuses: coding-standards
---------------------------+-------------------------------
Comment (by sabernhardt):
In PR 7500, I marked one line that should not be added in Twenty Twenty-
Two's [https://github.com/WordPress/wordpress-develop/pull/7500/files
#diff-0255170abdec9a032d8f1b0fbb5d10bdd5d2b199776b150f56da822627b0da72
block-patterns file] (out of 187 files).
Additional notes:
- The error is
[https://github.com/squizlabs/PHP_CodeSniffer/blob/c6c65ca0dc8608ba87631523b97b2f8d5351a854/src/Standards/Squiz/Sniffs/Commenting/FileCommentSniff.php#L133
'SpacingAfterComment' from PHPCS].
- [https://core.trac.wordpress.org/ticket/40039#comment:19 Core-40039]
only updated Twenty Seventeen and newer themes for different coding
standards two years ago. However, [59158] already made
'SpacingAfterComment' changes for Twenty Fourteen, and consistency is
good.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/62166#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list