[wp-trac] [WordPress Trac] #61648: WP_Debug_Data::debug_data() is overly complex

[WordPress Trac]

#61648: WP_Debug_Data::debug_data() is overly complex
----------------------------+-----------------------
 Reporter:  apermo          |       Owner:  dmsnell
     Type:  task (blessed)  |      Status:  reopened
 Priority:  normal          |   Milestone:  6.7
Component:  Site Health     |     Version:  6.6
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:
----------------------------+-----------------------
Changes (by dmsnell):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 @desrosj should we be making these formatting changes in separate tickets?
 I've wondered this question, because in order to ensure limited scope, the
 changes here have been focused on extracting code from the single large
 `debug_data()` method into separate task-specific sub-methods.

 there are a number of existing patterns in the code that I'm sure people
 want to change, but I'm worried that making those at the same time, or at
 least on the same ticket, as //moving// code from one place to another,
 will dilute the focus and history of what's happening.

 asking just in case the context wasn't clear - this ticket is not about
 introducing new code or changing coding patterns apart from splitting code
 off into chunks that can be more safely analyzed, reviewed, and tested in
 isolation.

 @davidbaumwald I'm going to re-open this as a `Task (Blessed)` for 6.7 and
 focus on getting the remaining work through before RC1, which I believe
 should be easy. thankfully, most of the questions arising from the
 refactor have been addressed, and while some additional ones may show up,
 I think the remainder of the sub-tasks will go smoothly.

 if this is not the right thing to do then I'm happy to change or create a
 new Ticket, such as `Finish the work of #61648 before RC1` or whatever is
 appropriate.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61648#comment:63>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform