[wp-trac] [WordPress Trac] #62153: Fix recording Performance Test results

WordPress Trac noreply at wordpress.org
Fri Oct 4 16:24:48 UTC 2024


#62153: Fix recording Performance Test results
--------------------------------------+--------------------------
 Reporter:  joemcgill                 |       Owner:  flixos90
     Type:  defect (bug)              |      Status:  closed
 Priority:  high                      |   Milestone:  6.7
Component:  Build/Test Tools          |     Version:  6.6
 Severity:  normal                    |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests  |     Focuses:  performance
--------------------------------------+--------------------------
Changes (by flixos90):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"59170" 59170]:
 {{{
 #!CommitTicketReference repository="" revision="59170"
 Build/Test Tools: Resolve access failure to continue sending commit
 performance data to Code Vitals dashboard.

 This originally broke in [58165] and unfortunately went unnoticed for a
 while because the failing request to send the data did not cause the
 GitHub workflows to fail. This changeset resolves the underlying access
 problem, which was happening because reusable GitHub workflows do not
 automatically receive secrets from the calling workflow. More concretely,
 the relevant `CODEVITALS_PROJECT_TOKEN` was not being explicitly passed to
 the reusable workflow.

 The changeset also includes a change so that in the future a failing
 request would cause the workflow to fail, which ensures a similar problem
 further down the road wouldn't go unnoticed.

 Props joemcgill, flixos90, swissspidy, mukesh27, sergeybiryukov
 Fixes #62153.
 See #61213.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/62153#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list