[wp-trac] [WordPress Trac] #60045: Change to add_new label displays wrong label for old post types

[WordPress Trac]

#60045: Change to add_new label displays wrong label for old post types
---------------------------------------------+----------------------------
 Reporter:  smerriman                        |       Owner:  rcreators
     Type:  defect (bug)                     |      Status:  assigned
 Priority:  normal                           |   Milestone:  6.7
Component:  Administration                   |     Version:  6.4
 Severity:  normal                           |  Resolution:
 Keywords:  good-first-bug has-patch commit  |     Focuses:  accessibility
---------------------------------------------+----------------------------
Changes (by joedolson):

 * keywords:  good-first-bug has-patch => good-first-bug has-patch commit


Comment:

 Updated PR to also apply to the two other uses of the `add_new` label, and
 updated function documentation.

 I don't see much of a use for `aria-label` here; with this change, there
 is no usage of `add_new` in core, so essentially this exists only for back
 compatibility, and we don't have any way of knowing where that parameter
 might be used in custom code.

 Marking for commit. This is effectively the same as it was before, except
 that core now references the `add_new_item` parameter instead of the
 `add_new` parameter. This seems more appropriate to me, since the phrase
 used is of the format "Add New {item}", not "Add New".

 Marking for commit.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60045#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform