[wp-trac] [WordPress Trac] #62162: Check PHPcs Coding standard into the wp-admin folder

[WordPress Trac]

#62162: Check PHPcs Coding standard into the wp-admin folder
--------------------------+----------------------
 Reporter:  viralsampat   |       Owner:  (none)
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:
Component:  General       |     Version:
 Severity:  normal        |  Resolution:  invalid
 Keywords:                |     Focuses:
--------------------------+----------------------
Changes (by sabernhardt):

 * keywords:  dev-feedback =>
 * status:  new => closed
 * resolution:   => invalid
 * milestone:  Awaiting Review =>


Comment:

 These proposed changes are not appropriate.

 1. Even if `Theme_Upgrader::delete_old_theme()` does not use the
 `$local_destination` and `$remote_destination` parameters, it uses the
 `$theme` parameter (at the end of the list) and the
 `upgrader_clear_destination` hook expects 4 arguments. All parameters need
 to stay in the method and its documentation.
 2. [54953] and [54954] already documented `$_wp_theme_features` in
 `WP_Debug_Data::debug_data()` and `$wpdb` in
 `WP_Debug_Data::get_database_size()`.
 3. [58745] already removed the `$mode` documentation in
 `WP_MS_Sites_List_Table::display_rows()`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/62162#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform