[wp-trac] [WordPress Trac] #62519: Trigger _doing_it_wrong in _load_textdomain_just_in_time() even when there are no translations

WordPress Trac noreply at wordpress.org
Mon Nov 25 16:00:38 UTC 2024


#62519: Trigger _doing_it_wrong in _load_textdomain_just_in_time() even when there
are no translations
-----------------------------+-----------------------------
 Reporter:  babelhalsupport  |       Owner:  (none)
     Type:  enhancement      |      Status:  reopened
 Priority:  normal           |   Milestone:  Future Release
Component:  I18N             |     Version:  6.7
 Severity:  normal           |  Resolution:
 Keywords:  dev-feedback     |     Focuses:
-----------------------------+-----------------------------

Comment (by babelhalsupport):

 Replying to [comment:8 swissspidy]:
 > The problem there is that this would also cause a warning if there are
 no translations installed yet, for example if the locale is set to en_US,
 or if the domain is spelled incorrectly.

 Actually when the domain is spelled incorrectly is also a doing_it_wrong
 scenario, even if another one.\\
 \\


 > I think one way to mitigate this is by landing #62244 first, which
 removes the need to call `load_plugin_textdomain()` at all. This reduces
 the likelihood of this warning being triggered for custom plugins.
 >
 > Second, we might want to give this a little bit more time before
 landing, maybe doing it only in a subsequent release.
 Agreed.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/62519#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list