[wp-trac] [WordPress Trac] #62424: Warning in wp_salt() since 6.7

[WordPress Trac]

#62424: Warning in wp_salt() since 6.7
-------------------------------------------------+-------------------------
 Reporter:  juliobox                             |       Owner:  desrosj
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  6.7.1
Component:  Options, Meta APIs                   |     Version:  6.7
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-screenshots has-       |     Focuses:
  testing-info commit                            |
-------------------------------------------------+-------------------------
Changes (by desrosj):

 * keywords:  has-patch has-screenshots has-testing-info reporter-feedback
     => has-patch has-screenshots has-testing-info commit


Comment:

 Did a little digging to see when this was added/changed to be this way. It
 seems that [54249]/#55937 wrapped the string in `__()` for WP 6.1, so it's
 relatively new.

 #57121 dealt with a similar edge case where `get_current_user_id()` cause
 out of memory errors. [55433] resolved this in 6.2.

 I'm not sure why this took until 6.7 to be reported. It's possible it just
 went unreported, but I'm wondering if this was a consequence of the
 changes related to just-in-time translations in [59157].

 I did some testing with the attached pull request, and it fixes the
 warnings and behaved as expected. This should hopefully catch the
 remaining edge cases.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/62424#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform