[wp-trac] [WordPress Trac] #62474: [ wp-includes/functions.php - number_format_i18n() ] - fallback in case number is not a float

[WordPress Trac]

#62474: [ wp-includes/functions.php - number_format_i18n() ] - fallback in case
number is not a float
-------------------------------------------------+-------------------------
 Reporter:  riccardodicurti                      |       Owner:  (none)
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  I18N                                 |     Version:
 Severity:  minor                                |  Resolution:
 Keywords:  has-patch has-testing-info has-      |     Focuses:
  screenshots dev-feedback close                 |
-------------------------------------------------+-------------------------

Comment (by SergeyBiryukov):

 Hi there, thanks for the ticket!

 This was previously discussed in #17299 and #35840, and the consensus was
 that we should not hide warnings caused by developer errors, unless there
 is a strong reason. It would just make debugging harder.

 If a valid parameter generates a warning, we should certainly fix that.
 However, in case of an invalid parameter, I think the warning (or an error
 on PHP 8.0+) is to be expected.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/62474#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform