[wp-trac] [WordPress Trac] #62474: [ wp-includes/functions.php - number_format_i18n() ] - fallback in case number is not a float

[WordPress Trac]

#62474: [ wp-includes/functions.php - number_format_i18n() ] - fallback in case
number is not a float
-------------------------------------------------+-------------------------
 Reporter:  riccardodicurti                      |       Owner:  (none)
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  I18N                                 |     Version:
 Severity:  minor                                |  Resolution:
 Keywords:  has-patch has-testing-info has-      |     Focuses:
  screenshots                                    |
-------------------------------------------------+-------------------------
Changes (by abcd95):

 * keywords:  has-patch => has-patch has-testing-info has-screenshots


Comment:

 Hey @riccardodicurti, Thanks for bringing this up.

 I was able to reproduce this issue. The problem occurs when non-numeric
 values are passed to `number_format_i18n()`.

 Reproduction Steps:

 Run:

 `number_format_i18n("abc");`     // Throws error



 ** Screenshots **

 * Before the patch - [[Image(https://postimg.cc/Fff6Q3Kj)]]
 * After the patch  - [[Image(https://postimg.cc/s10w31tm)]]

 Please let me know if we can do better!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/62474#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform