[wp-trac] [WordPress Trac] #62354: fetch_feed should use `get_bloginfo( 'charset' )` over `get_option( 'blog_charset' )` when setting the output encoding

WordPress Trac noreply at wordpress.org
Fri Nov 8 00:40:14 UTC 2024


#62354: fetch_feed should use `get_bloginfo( 'charset' )` over `get_option(
'blog_charset' )` when setting the output encoding
--------------------------+---------------------
 Reporter:  david.binda   |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  6.7.1
Component:  Feeds         |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+---------------------

Comment (by azaozz):

 > IMHO, the fetch_feed function should use the get_bloginfo( 'charset' )
 over the unchecked option value.

 This was added in #10713 from 15 years ago. Seems the reason the patch
 there is using `get_option()` is because `get_bloginfo( 'charset' )` was
 added later/wasn't available at the time.

 Frankly I'm thinking this fix should probably be in 6.7 as the fatal seems
 triggered by the SimplePie update. Looking at the PR, seems the only
 possibility of any problems might be because of the filter at the bottom
 of `get_bloginfo()`. Considering how close to release it is, maybe the
 patch for 6.7 can be to just fix this in `fetch_feed()`, but switch to
 using `get_bloginfo()` for 6.8+.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/62354#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list