[wp-trac] [WordPress Trac] #62269: WP_HTML_Processor::next_token() cannot be extended in subclasses to keep track of state

WordPress Trac noreply at wordpress.org
Wed Nov 6 19:22:38 UTC 2024


#62269: WP_HTML_Processor::next_token() cannot be extended in subclasses to keep
track of state
-------------------------------------------------+-------------------------
 Reporter:  westonruter                          |       Owner:
                                                 |  westonruter
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.7.1
Component:  HTML API                             |     Version:  6.5
 Severity:  normal                               |  Resolution:
 Keywords:  has-unit-tests has-patch fixed-      |     Focuses:
  major                                          |
-------------------------------------------------+-------------------------

Comment (by westonruter):

 In [changeset:"59364" 59364]:
 {{{
 #!CommitTicketReference repository="" revision="59364"
 HTML API: Improve private method name used by
 `WP_HTML_Processor::next_token()`.

 This renames the private `_next_token` method to `next_visitable_token`.
 It also removes irrelevant assertions from the unit test.

 Follow-up to [59285].

 Props dmsnell, jonsurrell, westonruter.
 See #62269.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/62269#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list