[wp-trac] [WordPress Trac] #62328: Theme JSON: replace top-level background style objects on merge

[WordPress Trac]

#62328: Theme JSON: replace top-level background style objects on merge
-------------------------------------------------+-------------------------
 Reporter:  ramonopoly                           |       Owner:  ramonopoly
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  6.8
Component:  Themes                               |     Version:
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests gutenberg-  |     Focuses:
  merge                                          |
-------------------------------------------------+-------------------------
Changes (by ramonopoly):

 * owner:  (none) => ramonopoly
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"59335" 59335]:
 {{{
 #!CommitTicketReference repository="" revision="59335"
 Theme JSON: replace top-level background style objects on merge

 This commit fixes an omission in the logic of `WP_Theme_JSON::merge()`
 where top-level background image style objects are not replaced, rather
 they are merged. Because background images are self contained objects,
 their properties are unique and should not be merged. Blocks are already
 catered for via `WP_Theme_JSON::get_block_nodes()`.

 Follow-up to [61858].

 Props ramonopoly, andrewserong.
 Fixes #62328.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/62328#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform