[wp-trac] [WordPress Trac] #61103: update all update_option calling in core to set the autoload option

[WordPress Trac]

#61103: update all update_option calling in core to set the autoload option
--------------------------------+------------------------------
 Reporter:  pbearne             |       Owner:  pbearne
     Type:  defect (bug)        |      Status:  assigned
 Priority:  normal              |   Milestone:  Awaiting Review
Component:  Options, Meta APIs  |     Version:
 Severity:  normal              |  Resolution:
 Keywords:  has-patch           |     Focuses:  performance
--------------------------------+------------------------------

Comment (by pbearne):

 I thought it might help to list the options I propose, not to autoload,
 that are currently not unset in core.

 update_option( 'auto_plugin_theme_update_emails', $past_failure_emails,
 false );
 update_option( 'recently_activated', $recently_activated, false );
 update_option( '_wp_suggested_policy_text_has_changed', $state, false );
 update_option( $lock_option, time(), false );
 update_option( 'dashboard_widget_options', $widget_options, false );
 update_option( 'ftp_credentials', $stored_credentials, false );
 update_option( 'recently_edited', $oldfiles, false );
 update_option( 'adminhash', $new_admin_email, false );
 update_option( 'nav_menu_options', $nav_menu_option, false );
 update_option( 'active_plugins', $current, false );
 update_option( 'uninstall_plugins', $uninstallable_plugins, false );
 update_option( 'wp_force_deactivated_plugins', array(), false );
 update_option( 'delete_blog_hash', $hash, false );
 update_option( 'allowedthemes', $allowed_themes, false );
 update_option( 'admin_email', $new_admin_details['newemail'], false );
 update_option( 'recently_activated', $recent, false );
 update_option( 'https_detection_errors', $support_errors->errors, false );
 update_option( 'fresh_site', '0', false );
 update_option( 'upload_path', UPLOADBLOGSDIR . "/$blog_id/files", false );
 update_option( 'admin_email', '', false );
 update_option( 'admin_email_lifespan', time() + $remind_interval, false );

 src/wp-includes/class-wp-paused-extensions-storage.php
 return update_option( $option_name, $paused_extensions, false );

 src/wp-includes/class-wp-recovery-mode-key-service.php
 return update_option( $this->option_name, $keys, false );

 this is one that we may not want to set false
 update_option( 'widget_' . $id_base, $widget, false );

 Please review this list and comment if any of these need to be autoload
 (as needed by the front-end)
 I hope we can get this change in, as this will free some memory.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61103#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform