[wp-trac] [WordPress Trac] #39281: Twenty Seventeen: header.php forces thumbnails on all post types

[WordPress Trac]

#39281: Twenty Seventeen: header.php forces thumbnails on all post types
-------------------------------------------------+-------------------------
 Reporter:  justnorris                           |       Owner:  (none)
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.6
Component:  Bundled Theme                        |     Version:  4.8
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-         |     Focuses:  ui,
  testing-info                                   |  template
-------------------------------------------------+-------------------------

Comment (by lamarajan):

 Hello  @poena and @nhrrob,

 I have tested as per given instructions with PR.

 Expected Results
 When testing a patch to validate it works as expected:
 ✅ On the single post and the single page, the featured image shows.
 Assign one of the pages as the front page:
 Go to the WordPress admin, Settings, Reading, and change
 "Your homepage displays" to a static page, and select the page you just
 created.
 >> PASS

 Expected Results
 When testing a patch to validate it works as expected:
 ✅ The theme header image and the page featured image shows once.
 To test the filter, add the following in functions.php after
 twentyseventeen_should_show_featured_image(), or in a child theme or
 plugin:
 add_filter( 'twentyseventeen_should_show_featured_image', '__return_false'
 );
 >> PASS

 Expected Results
 When testing a patch to validate it works as expected:
 ✅ On the static front page with the page assigned, the theme header image
 and the page featured image should show once.
 >> PASS

 ✅ On the single post and the single page, the featured image should not
 show.
 It is working as aspected.
 >> PASS

 I have also attached the screenshot.

 Thanks,
 Rajan Lama (@lamarajan)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/39281#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform