[wp-trac] [WordPress Trac] #58539: Twenty Seventeen: Image block figcaption text alignment inconsistency

WordPress Trac noreply at wordpress.org
Mon May 6 17:37:06 UTC 2024


#58539: Twenty Seventeen: Image block figcaption text alignment inconsistency
-----------------------------------------------------+---------------------
 Reporter:  nkeller15                                |       Owner:  (none)
     Type:  defect (bug)                             |      Status:  new
 Priority:  normal                                   |   Milestone:  6.6
Component:  Bundled Theme                            |     Version:  5.8
 Severity:  normal                                   |  Resolution:
 Keywords:  has-patch has-screenshots needs-testing  |     Focuses:  css
-----------------------------------------------------+---------------------
Changes (by sabernhardt):

 * keywords:  has-patch has-screenshots => has-patch has-screenshots needs-
     testing
 * milestone:  Awaiting Review => 6.6


Comment:

 #56747 has the same basic issue but discusses additional possibilities.
 This ticket could correct the mismatch for now.

 [attachment:"58539.2.diff"] updates the existing rulesets to include
 selectors for multiple situations:
 1. It adds selectors with `[class*=" wp-block-"]` because that class name
 is not the first in the list anymore.
 2. It uses the child combinator `[class*=" wp-block-"]:not(.wp-block-
 gallery) > figcaption` so the styles that do not fit the Gallery block
 captions do not apply to Gallery blocks within a Group or Column block
 (see #50376).
 3. Selectors for RTL languages include `[dir="rtl"]` because the iframe
 editor does not use the `.rtl` class. It probably does not need
 `[dir="rtl"] [class^="wp-block-"]:not(.wp-block-gallery) > figcaption`,
 but I added that to follow the pattern.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58539#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list