[wp-trac] [WordPress Trac] #60706: Tests: Reduce usage of assertEquals for 6.6

WordPress Trac noreply at wordpress.org
Wed May 1 18:54:51 UTC 2024


#60706: Tests: Reduce usage of assertEquals for 6.6
--------------------------------------+---------------------
 Reporter:  SergeyBiryukov            |       Owner:  (none)
     Type:  task (blessed)            |      Status:  new
 Priority:  normal                    |   Milestone:  6.6
Component:  Build/Test Tools          |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+---------------------

Comment (by SergeyBiryukov):

 In [changeset:"58070" 58070]:
 {{{
 #!CommitTicketReference repository="" revision="58070"
 Tests: Use `assertSame()` in `wp_validate_redirect()` tests.

 This ensures that not only the return values match the expected results,
 but also that their type is the same.

 Going forward, stricter type checking by using `assertSame()` should
 generally be preferred to `assertEquals()` where appropriate, to make the
 tests more reliable.

 Follow-up to [36444].

 Props costdev.
 See #60706.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60706#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list