[wp-trac] [WordPress Trac] #56524: Twenty Eleven: "Add Citation" Text Color issue in Pullquote Block

WordPress Trac noreply at wordpress.org
Thu Mar 28 20:43:43 UTC 2024


#56524: Twenty Eleven:  "Add Citation" Text Color issue in Pullquote Block
---------------------------+-------------------------
 Reporter:  kajalgohel     |       Owner:  karmatosed
     Type:  defect (bug)   |      Status:  closed
 Priority:  normal         |   Milestone:  6.6
Component:  Bundled Theme  |     Version:  6.0.2
 Severity:  normal         |  Resolution:  fixed
 Keywords:  has-patch      |     Focuses:  ui, css
---------------------------+-------------------------
Changes (by sabernhardt):

 * keywords:  has-patch commit => has-patch
 * milestone:  Awaiting Review => 6.6


Comment:

 Inheriting the text color affects the citation color when the user does
 not select a color for the block, yet **in this case** it seems
 reasonable.

 - [43794] only added the `#141412` color in `blocks.css`, not `editor-
 blocks.css`, and I did not find that color anywhere else in Twenty Eleven.
 - The difference between `#141412` and `#373737` is minor with a ratio of
 1.54:1 (or against a white background, the ratios are 18.44:1 for
 `#141412` and 11.9:1 for `#373737`).
 - The code change in [57896] is simpler than adjusting the color only when
 the block has the `.has-text-color` and/or `.has-background` classes.

 For the screenshots, I edited the `code` element `font-size` and/or `text-
 transform` to make the inline code more readable. The colors and other
 styles should be accurate.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56524#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list