[wp-trac] [WordPress Trac] #43633: Duplicate links to edit profile dropdown in toolbar

[WordPress Trac]

#43633: Duplicate links to edit profile dropdown in toolbar
-------------------------+------------------------
 Reporter:  danieltj     |       Owner:  joedolson
     Type:  enhancement  |      Status:  reopened
 Priority:  normal       |   Milestone:  6.5
Component:  Toolbar      |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  ui
-------------------------+------------------------
Changes (by sabernhardt):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 I added a patch to fix some things, but we could consider reverting this
 part of [57708] instead and revisiting to the duplicate links in another
 release cycle.

 - The separate "Edit Profile" link needed an `if ( false !== $profile_url
 )` condition for users without a role in [34122], and it should continue
 to check that condition for the text.
 - Also for users without a role, the profile menu `div` would need the
 zero `tabindex` to be focusable (more related to #34668). The parameter
 checks for an integer, and I chose an empty string for the usual case of
 no `tabindex`. Another possibility is giving //any// `( $is_parent && !
 $has_link )` node the zero `tabindex`, but there may have been a reason
 not to do that when the parameter was added.
 - The 12-pixel `row-gap` added to the combined link is too much space on
 Make Core and likely in other conditions too. I simply removed it in the
 patch for now. Editing the `height`, `line-height` and/or `font-size`
 could be better.
 - 43633.4.diff specifically had the `display-name` class before the new
 class for the Edit Profile `span`. This was an easy way to match its
 styles to the display name `span` without editing the color palettes. In
 addition to the color, smaller screens need the adjustments to `font-
 size`, `line-height` and `height`.
 - Additional edits in the patch include an extra space after 'meta' to
 align the array values, capitalizing the ARIA acronym, and adding a
 translator comment. These changes could be made if reverting is the better
 option.

 The profile menu also does not show the image/icon on smaller screens when
 the site enables avatars and the user has no role, but that bug is older
 so I did not add absolute positioning for the image within this patch.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43633#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform