[wp-trac] [WordPress Trac] #60663: Plugin Cards: Links with `.button-disabled` are still clickable
WordPress Trac
noreply at wordpress.org
Fri Mar 1 03:04:20 UTC 2024
#60663: Plugin Cards: Links with `.button-disabled` are still clickable
--------------------------+-----------------------
Reporter: costdev | Owner: costdev
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 6.5
Component: Plugins | Version:
Severity: normal | Keywords: has-patch
Focuses: |
--------------------------+-----------------------
Props to @swissspidy for noticing this while testing Plugin Dependencies.
Currently, links with a `href` attribute and the `.button-disabled` class
are still clickable.
We should prevent the default `click` handling for elements with the
`.button-disabled` class.
While this appears to have been the case in earlier WordPress versions, it
may be more apparent in the increased AJAX-ified experience added by the
Plugin Dependencies feature.
**Milestoning for 6.5 for awareness, though I welcome thoughts on whether
this is something that needs to be handled in 6.5, or should wait until
6.6.**
== Testing Instructions
These steps define how to reproduce the issue, and indicate the expected
behavior.
=== Steps to Reproduce
1. Navigate to `Plugins > Add New Plugin`.
2. Click "Install Now".
3. Once installed, click "Activate".
4. 🐞 Once activated, click on the disabled "Active" button.
=== Expected Results
When testing a patch to validate it works as expected:
- ✅ The link does not work.
When reproducing a bug:
- ❌ The link still works despite the `.button-disabled` class being
present.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/60663>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list