[wp-trac] [WordPress Trac] #60328: Deprecated parameter default value of unregister_setting() is not correct type

[WordPress Trac]

#60328: Deprecated parameter default value of unregister_setting() is not correct
type
-----------------------------------------+------------------------------
 Reporter:  crstauf                      |       Owner:  audrasjb
     Type:  defect (bug)                 |      Status:  reviewing
 Priority:  normal                       |   Milestone:  Awaiting Review
Component:  General                      |     Version:
 Severity:  normal                       |  Resolution:
 Keywords:  has-patch changes-requested  |     Focuses:  docs
-----------------------------------------+------------------------------

Comment (by gerardreches):

 Replying to [comment:5 audrasjb]:
 > Makes sense to me, just maybe replace `&&` with `||` ;)
 >
 > Removing `needs-unit-tests` since it wouldn't need any unit test update
 in that case.

 Maybe I'm a bit confused, but why `||` instead of `&&`? Aren't we trying
 to run what's inside the conditional if `$deprecated` has been set to
 something that is not the default value?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60328#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform