[wp-trac] [WordPress Trac] #59866: Attachment pages are only disabled for users that are logged in

[WordPress Trac]

#59866: Attachment pages are only disabled for users that are logged in
----------------------------------------------------+---------------------
 Reporter:  joppuyo                                 |       Owner:  (none)
     Type:  defect (bug)                            |      Status:  new
 Priority:  normal                                  |   Milestone:  6.4.3
Component:  Media                                   |     Version:  6.4
 Severity:  normal                                  |  Resolution:
 Keywords:  has-patch needs-testing has-unit-tests  |     Focuses:
----------------------------------------------------+---------------------

Comment (by peterwilsoncc):

 I think the approach in [attachment:"59866-cp.diff"] makes sense.

 In the [https://github.com/WordPress/wordpress-develop/pull/5877 linked
 pull request] I've added tests for the following situations:

 * no post parent, logged out user
 * no post parent, logged in user
 * private post parent, logged out user
 * private post parent, logged in user
 * public post parent, logged out user
 * public post parent, logged in user

 I've switched to a data provider as there's enough of an increase in the
 tests that I didn't want to add any more near repeats.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59866#comment:33>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform