[wp-trac] [WordPress Trac] #60524: Cropping site icon should preserve attachment properties

[WordPress Trac]

#60524: Cropping site icon should preserve attachment properties
-------------------------------------------------+-------------------------
 Reporter:  afercia                              |       Owner:  rcreators
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  6.5
Component:  Media                                |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch 2nd-opinion needs-unit-    |     Focuses:
  tests                                          |  accessibility
-------------------------------------------------+-------------------------
Changes (by swissspidy):

 * keywords:  has-patch 2nd-opinion => has-patch 2nd-opinion needs-unit-
               tests


Comment:

 The `create_attachment_object` method should be marked deprecated and not
 directly removed from core. Especially since it is public and used in the
 ecosystem.

 By the way, that method has some unit tests, can this be used as a
 starting point to add some test coverage for this newly proposed
 `wp_copy_parent_attachment_properties` function as well?

 Also, just noting that 6.5 RC1 is approaching soon, so this would need to
 land before that or else we should punt it to 6.6.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60524#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform