[wp-trac] [WordPress Trac] #54370: Add an option to configure the site icon in general settings

[WordPress Trac]

#54370: Add an option to configure the site icon in general settings
----------------------------------------------+-----------------------
 Reporter:  jameskoster                       |       Owner:  jorbin
     Type:  task (blessed)                    |      Status:  reopened
 Priority:  normal                            |   Milestone:  6.5
Component:  General                           |     Version:  5.9
 Severity:  normal                            |  Resolution:
 Keywords:  has-screenshots has-patch commit  |     Focuses:
----------------------------------------------+-----------------------

Comment (by kebbet):

 Thanks for bringing this closer to a commit @jorbin  and @swissspidy!

 Testing functionallity: looks good and works as expteced. Alt texts are
 displayed with correct content on page load and after selection in modal.
 Cropping works, and the preview in the modal looks ok. RTL works to.

 Looking at the code: looks ok from my point of view. Only nitpick is this
 comment, that stands out in it's tone.
 `Start over with a frame that is so fresh and so clean clean.`

 Otherwise ok, and I like the direction with a new ticket for design update
 over all. The preview looks a bit dated.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54370#comment:121>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform