[wp-trac] [WordPress Trac] #59655: Tests: Reduce usage of assertEquals for 6.5
WordPress Trac
noreply at wordpress.org
Sun Feb 18 18:59:40 UTC 2024
#59655: Tests: Reduce usage of assertEquals for 6.5
--------------------------------------+---------------------
Reporter: hellofromTonya | Owner: (none)
Type: task (blessed) | Status: new
Priority: normal | Milestone: 6.5
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+---------------------
Comment (by SergeyBiryukov):
In [changeset:"57653" 57653]:
{{{
#!CommitTicketReference repository="" revision="57653"
Tests: Use `assertSame()` in `WP_Query` tests involving
`::$max_num_pages` property.
This ensures that not only the return values match the expected results,
but also that their type is the same.
Going forward, stricter type checking by using `assertSame()` should
generally be preferred to `assertEquals()` where appropriate, to make the
tests more reliable.
Follow-up to [48937], [54402], [54768], [57648].
Props costdev.
See #58683, #59655.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/59655#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list