[wp-trac] [WordPress Trac] #58087: Fix the 'data' dynamic property in WP_Term

[WordPress Trac]

#58087: Fix the 'data' dynamic property in WP_Term
-------------------------------------+-------------------------------------
 Reporter:  antonvlasenko            |       Owner:  hellofromTonya
     Type:  defect (bug)             |      Status:  reviewing
 Priority:  normal                   |   Milestone:  6.5
Component:  Taxonomy                 |     Version:  6.3
 Severity:  minor                    |  Resolution:
 Keywords:  php82 has-patch has-     |     Focuses:  coding-standards, php-
  unit-tests needs-testing changes-  |  compatibility
  requested                          |
-------------------------------------+-------------------------------------

Comment (by hellofromTonya):

 This issue was discussed
 [https://www.youtube.com/live/vDZWepDQQVE?si=OuXG1eFif76ZqqoK&t=13340
 during a live working session] with @jrf @markjaquith and me.

 My apologies for not summarizing the discussion earlier when this ticket
 was first opened.

 From that session, the thinking and next steps:

 * It's constructor work.
 * `data` is publicly exposed through `__get()` though checking `isset()`
 will always return `false` since `__isset()` was not implemented.
 * Search Core for any usages.
 * Search plugins for any usages. But the results will be imprecise and
 possibly misleading. ✅
 * Do a deeper dive is essential to better understand the reasoning for its
 design. Done comment:4 ✅
 * Consider the original reasoning against the thinking of it being
 constructor work.

 Does the original reasoning support moving it to the constructor? Thinking
 through that now.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58087#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform