[wp-trac] [WordPress Trac] #54370: Add an option to configure the site icon in general settings
WordPress Trac
noreply at wordpress.org
Thu Feb 15 10:02:20 UTC 2024
#54370: Add an option to configure the site icon in general settings
---------------------------------------+-----------------------
Reporter: jameskoster | Owner: jorbin
Type: task (blessed) | Status: reopened
Priority: normal | Milestone: 6.5
Component: General | Version: 5.9
Severity: normal | Resolution:
Keywords: has-screenshots has-patch | Focuses:
---------------------------------------+-----------------------
Comment (by afercia):
For better coordination: @kebbet is working on a PR to address the missing
points reported above, see https://github.com/WordPress/wordpress-
develop/pull/6109/
I left some comments there, everyone is welcome to contribute to that PR.
> > The accessibility feedback from https://github.com/WordPress
/wordpress-develop/pull/6064#pullrequestreview-1872283972 hasn't been
addressed.
> It was addressed, even if you don't agree with it ...
I'm sorry I was not clear then. The feedback is not addressed because the
main point is that there's no textual information about the currently
selected image. Screen reader users won't have any clue what the selected
image is. Alternative text like 'Preview as a browser icon' or 'Preview as
an app icon' only explain the visuals of the UI, which I'd say it's not
relevant. Instead, there should be some information about the currently
selected image.
> The linting does not detect any issues, but happy to look through it
with a finer eye.
This isn't new. The linter only catches some suntax error. WorfPress never
had a tool to check all the JS coding standards as detailed at
https://developer.wordpress.org/coding-standards/wordpress-coding-
standards/javascript/
It has been discussed since 2016 at least, I think, and there's a Trac
ticket open since years but no actual progress so far.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/54370#comment:84>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list