[wp-trac] [WordPress Trac] #60071: wp_list_authors with exclude_admin=true does not exclude administrators

[WordPress Trac]

#60071: wp_list_authors with exclude_admin=true does not exclude administrators
-----------------------------------+------------------------
 Reporter:  juliobox               |       Owner:  (none)
     Type:  enhancement            |      Status:  closed
 Priority:  normal                 |   Milestone:
Component:  Users                  |     Version:  1.2
 Severity:  normal                 |  Resolution:  duplicate
 Keywords:  has-patch 2nd-opinion  |     Focuses:
-----------------------------------+------------------------

Comment (by knyjicamymepo1997):

 Thank you for bringing this to attention! It appears there is an issue
 with the `wp_list_authors()` function not properly excluding
 administrators when the `exclude_admin` parameter is set to `true`. This
 discrepancy in behavior could potentially lead to unintended results, such
 as administrators being displayed despite the intention to exclude them.

 In the current implementation of `wp_list_authors()`, the exclusion of
 administrators is checked by comparing the display name of the author with
 the string 'admin'. However, as you correctly pointed out, this approach
 may not cover all cases, especially when users customize their display
 names or when non-English installations are used.

 To address this issue and ensure administrators are properly excluded from
 the list of authors, it is suggested to modify the conditional statement
 to check the user roles instead. By checking if the user has the
 'administrator' role, we can reliably exclude administrators from the list
 regardless of their display names.

 Here's the proposed modification:

 ```php
 if ( $parsed_args['exclude_admin'] && in_array( 'administrator', (array)
 $author->roles ) ) {
 ```

 With this modification, the `wp_list_authors()` function will correctly
 exclude administrators from the list of authors when the `exclude_admin`
 parameter is set to `true`. This approach is more robust and future-proof,
 ensuring consistent behavior across different WordPress installations and
 configurations.

 It's important to note that while `wp_list_authors()` is an older function
 dating back to version 1.2 of WordPress, it still remains relevant and
 widely used in various contexts, particularly for displaying lists of
 authors on WordPress sites.

 In summary, by making the suggested code modification, developers can
 ensure that administrators are properly excluded from the list of authors
 generated by `wp_list_authors()`, thereby maintaining the intended
 functionality of the function. Thank you once again for highlighting this
 issue and providing the recommended solution!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60071#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform