[wp-trac] [WordPress Trac] #60474: HTML API: HTML Processor bookmarks seek, has_bookmark bugs

[WordPress Trac]

#60474: HTML API: HTML Processor bookmarks seek, has_bookmark bugs
--------------------------------------+------------------------------
 Reporter:  jonsurrell                |       Owner:  jonsurrell
     Type:  defect (bug)              |      Status:  closed
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  HTML API                  |     Version:
 Severity:  normal                    |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+------------------------------
Changes (by dmsnell):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"57582" 57582]:
 {{{
 #!CommitTicketReference repository="" revision="57582"
 HTML API: Add subclassed has_bookmark() and fix seek()

 The WP_HTML_Processor::has_bookmark() method has not correctly reported
 bookmarks
 which have been set, because it wraps the given bookmark names when
 setting them.
 Additionally, WP_HTML_Processor::seek() does not seek to correct location
 if HTML
 has been updated because it wasn't flushing enqueued updates to the
 document.

 In this patch both problems are resolved and added tests guard these
 behaviors
 against future regressions.

 Developed in https://github.com/WordPress/wordpress-develop/pull/6039
 Discussed in https://core.trac.wordpress.org/ticket/60474

 Follow-up to [56274].
 Props dmsnell, jonsurrell.
 Fixes #60474.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60474#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform