[wp-trac] [WordPress Trac] #60862: wp_localize_script() on login_enqueue_scripts hook change in behavior

WordPress Trac noreply at wordpress.org
Fri Apr 26 18:54:05 UTC 2024


#60862: wp_localize_script() on login_enqueue_scripts hook change in behavior
---------------------------+---------------------
 Reporter:  salcode        |       Owner:  (none)
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  6.5.3
Component:  Script Loader  |     Version:  6.5
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:
---------------------------+---------------------

Comment (by aslamdoctor):

 @jorbin just checked the e2e test and it seems to be working as expected.

 few points:
 1. Do we need the console.log() on this line ?
 https://github.com/WordPress/wordpress-develop/pull/6334/files#diff-
 ac85ccb848d1c1b4eaa345b6e66b79d32edfa6ad891e91448b4ce3b09b043671R16

 2. Now, as this e2e test is the proper way to test this patch, should we
 remove the PHPUnit test?

 3. I noticed there are some errors on E2E test on github repo which are
 related to file not found at /mu-plugins/login.php file. Should we be
 concerned about this?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60862#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list