[wp-trac] [WordPress Trac] #60977: "Edit site" means two different things on a Multisite network

WordPress Trac noreply at wordpress.org
Mon Apr 22 20:52:53 UTC 2024


#60977: "Edit site" means two different things on a Multisite network
-------------------------------------+-------------------------------------
 Reporter:  johnbillion              |       Owner:  audrasjb
     Type:  enhancement              |      Status:  accepted
 Priority:  normal                   |   Milestone:  6.6
Component:  Toolbar                  |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  good-first-bug has-      |     Focuses:  administration,
  patch commit                       |  multisite
-------------------------------------+-------------------------------------
Changes (by audrasjb):

 * keywords:  good-first-bug has-patch => good-first-bug has-patch commit


Comment:

 The patch looks good to me, thanks!

 Replying to [comment:8 sabernhardt]:
 > I like that the string 'Site Editor' is
 [https://translate.wordpress.org/projects/wp/dev/admin/fr-
 ca/default/?filters%5Btranslation_id%5D=99918177 already translated],
 though its current use is in the theme administration's
 [https://build.trac.wordpress.org/browser/trunk/wp-
 admin/includes/theme.php?marks=342#L342 features list] (since 6.1.1 with
 [54786]). I did not notice a problem with reusing it in this context, but
 could that be inappropriate?

 In this cas, there is no problem reusing it without adding a translating
 context since it's about the very same thing, so I think the patch can
 ship as it is. Thanks for checking! :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60977#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list