[wp-trac] [WordPress Trac] #60922: get_custom_logo returns an empty link when no logo image is set

[WordPress Trac]

#60922: get_custom_logo returns an empty link when no logo image is set
--------------------------+----------------------------
 Reporter:  afercia       |       Owner:  joedolson
     Type:  defect (bug)  |      Status:  accepted
 Priority:  normal        |   Milestone:  6.6
Component:  Themes        |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:  accessibility
--------------------------+----------------------------
Changes (by joedolson):

 * keywords:   => needs-patch
 * owner:  (none) => joedolson
 * status:  new => accepted
 * milestone:  Awaiting Review => 6.6


Comment:

 I think that the scenarios where this will be triggered are relatively
 uncommon, since most of the time when somebody removes their site logo
 they'll notice the impact on their site and change it. However, we can
 protect against this problem relatively easily.

 There are two aspects to address: 1) unsetting the theme mod when the site
 logo is deleted and 2) correctly handling the case where
 `wp_get_attachment_image` returns an empty string.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60922#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform