[wp-trac] [WordPress Trac] #60913: Remove unnecessary code for ensuring interactivity API dependency in block core functions
WordPress Trac
noreply at wordpress.org
Mon Apr 8 18:49:38 UTC 2024
#60913: Remove unnecessary code for ensuring interactivity API dependency in block
core functions
------------------------------------+-----------------------
Reporter: czapla | Owner: czapla
Type: enhancement | Status: assigned
Priority: normal | Milestone: 6.6
Component: Editor | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch dev-feedback | Focuses:
------------------------------------+-----------------------
Comment (by czapla):
> IMHO this can wait until 6.6
makes sense 👍
> Do we know how many plugins/themes are using these functions? Is
outreach necessary?
I don't really know how we could know how many plugins/themes are using
it. However, prior to 6.5 the Interactivity API was explicitly a private
API so I hope that this number is zero.
Technically, people could have added the Interactivity API as a dependency
in the same way as it was done for the core blocks
([https://github.com/WordPress/wordpress-develop/pull/6354/files#diff-
60bfb7515d59c661edb766cad1e85158fd5e4a8fe81523e3b4088d11f5231a4fL6300
link]).
No-oping the `block_core_image_ensure_interactivity_dependency` &
`block_core_file_ensure_interactivity_dependency` functions should be fine
because the File and Image blocks now use the module version of the
Interactivity API. So, if we [remove https://github.com/WordPress
/wordpress-develop/pull/6354/files#diff-
14577b710f11306118fa14601c82e5831f97b353025bfec3b59d9db9c49ecceaL285-L286]
the private version of the API, those functions don't do anything.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/60913#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list