[wp-trac] [WordPress Trac] #58281: Rollback Auto-Update (Rollback part 3)

[WordPress Trac]

#58281: Rollback Auto-Update (Rollback part 3)
--------------------------------------------------+-----------------------
 Reporter:  afragen                               |       Owner:  afragen
     Type:  enhancement                           |      Status:  assigned
 Priority:  normal                                |   Milestone:  6.4
Component:  Upgrade/Install                       |     Version:  6.3
 Severity:  normal                                |  Resolution:
 Keywords:  has-patch dev-feedback needs-testing  |     Focuses:
--------------------------------------------------+-----------------------

Comment (by peterwilsoncc):

 I've tested [https://github.com/WordPress/wordpress-develop/pull/3958 the
 linked pull request] on our old friend Chassis running on VirtualBox and
 am seeing some apparent timeouts.

 I wrote up a mini-plugin to
 [https://gist.github.com/peterwilsoncc/b140d56e61f80b6ba04e2a1ba7d6ab46
 increase the frequency the update cron jobs run] so I didn't need to wait
 twelve hours for each round of testing. This allowed me to use `wp-
 cron.php` for events to emulate real world circumstances.

 I then installed the following plugins:

 * akismet 4.1.10
 * gutenberg 16.5.1
 * jetpack 11.3.2
 * mailpoet 4.0.1
 * soliloquy-lite 2.5.2.8
 * woocommerce 7.0.0
 * wordpress-seo 19.7
 * wpforms-lite 1.7.0

 Running with the pull request checked out, the updates were failing with
 the setup mentioned above. Aksimet, Gutenberg and Jetpack would update but
 the rest of them would fail to upgrade.

 As the upgrade failed, no email notification was sent and the
 `auto_updater.lock` option would stay in the database preventing the next
 run from completing.

 I am wondering if the PHP request is timing out. In wp-cron.php, one of
 the first things that runs is [https://github.com/WordPress/wordpress-
 develop/blob/c1c0aeea5760cbb2194d8ba0accc428414f0174e/src/wp-
 cron.php#L26-L31 fast-finish code] to prevent the requests from blocking
 sites. I am wondering if this is preventing the timeout from being
 extended when the updates begin running.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58281#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform