[wp-trac] [WordPress Trac] #59394: Fix failing unit tests

WordPress Trac noreply at wordpress.org
Tue Sep 19 17:13:50 UTC 2023


#59394: Fix failing unit tests
-------------------------------------------------+-------------------------
 Reporter:  desrosj                              |       Owner:  costdev
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.4
Component:  Build/Test Tools                     |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests commit      |     Focuses:
  fixed-major                                    |
-------------------------------------------------+-------------------------

Comment (by costdev):

 In [changeset:"56624" 56624]:
 {{{
 #!CommitTicketReference repository="" revision="56624"
 Build/Test Tools: Add `sys_get_temp_dir()` to `open_basedir` tests.

 In PHPUnit 10.3.5, 9.6.13 and 8.5.34, the child processes used for process
 isolation now use temporary files to communicate their result to the
 parent process.

 This caused a failure in some tests that set the `open_basedir` PHP
 directive to a value that did not include `sys_get_temp_dir()`.

 This adds `sys_get_temp_dir()` to the `open_basedir` value set by the
 tests to ensure that permission is still granted for the temporary
 directory.

 PHPUnit uses `sys_get_temp_dir()`. To ensure the result is the same,
 Core's `get_temp_dir()` function is not used.

 References:
 - https://github.com/sebastianbergmann/phpunit/issues/5356

 Props desrosj, mukesh27, SergeyBiryukov, costdev.
 Merges [56622] to the 6.3 branch.
 See #59394.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59394#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list