[wp-trac] [WordPress Trac] #59334: In Theme Twenty Nineteen, Twenty seventeen & Twenty Twenty-Two Comment section Reply and cancel reply has no space between them

WordPress Trac noreply at wordpress.org
Thu Sep 14 14:59:45 UTC 2023


#59334: In Theme Twenty Nineteen, Twenty seventeen & Twenty Twenty-Two Comment
section Reply and cancel reply has no space between them
-----------------------------+------------------------------
 Reporter:  pitamdey         |       Owner:  (none)
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Bundled Theme    |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  has-screenshots  |     Focuses:  ui, css
-----------------------------+------------------------------
Changes (by sabernhardt):

 * component:  Comments => Bundled Theme


Comment:

 This might be fixable by adding a space in the comment reply JS instead
 (#51589), but you proposed changing theme styles.

 Notes:
 - Twenty Seventeen uses `em` measurements for most margins. Its margin for
 could go in the [https://github.com/sabernhardt/wordpress-
 develop/blob/1cce85d553af239a9b3d5816af0af808a4f7b2a3/src/wp-
 content/themes/twentyseventeen/style.css#L2477 comment-reply area of the
 stylesheet].
 - Twenty Nineteen likewise could use `0.5em` (or `0.5rem`) as a margin.
 That theme's styles need to be edited in
 [https://github.com/WordPress/twentynineteen/blob/be850d11ee31434ad700db518ff8570f82e65b9c/sass/site/primary/_comments.scss#L141
 SCSS] and then compiled.
 - Twenty Twenty-Two only needs a correction in the legacy version of the
 Comments block; the
 [https://github.com/WordPress/gutenberg/blob/a8c5605f5dd077a601aefce6f58409f54d7d4447/packages
 /block-library/src/post-comments-form/style.scss#L75 newer block adds a
 margin] of `0.5em`. To avoid RTL issues, we could try a pseudo-element
 before the `small` element.
 {{{
 .wp-block-post-comments .comment-reply-title > small::before {
   content: "";
   display: inline-block;
   width: 0.5em;
   height: 1em;
 }
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59334#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list