[wp-trac] [WordPress Trac] #59761: download_url DocBloc suggests to use unlink() over wp_delete_file()

WordPress Trac noreply at wordpress.org
Sun Oct 29 00:13:38 UTC 2023


#59761: download_url DocBloc suggests to use unlink() over wp_delete_file()
-------------------------+-------------------------------------
 Reporter:  bedas        |       Owner:  (none)
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  HTTP API     |     Version:  trunk
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  docs, coding-standards
-------------------------+-------------------------------------

Comment (by SergeyBiryukov):

 Hi there, thanks for the ticket!

 Depending on the context, it looks like moving the temporary file to
 another location might also be common here, so instead of mentioning
 `unlink()` or `wp_delete_file()` specifically, perhaps the DocBlock could
 just state that the calling function must delete or move the file.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59761#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list