[wp-trac] [WordPress Trac] #59935: Site editor: logo
WordPress Trac
noreply at wordpress.org
Wed Nov 29 19:23:01 UTC 2023
#59935: Site editor: logo
-------------------------------------------------+-------------------------
Reporter: priethor | Owner:
| hellofromTonya
Type: defect (bug) | Status: accepted
Priority: normal | Milestone: 6.4.2
Component: Editor | Version: 6.4
Severity: normal | Resolution:
Keywords: has-testing-info has-unit-tests | Focuses: rest-api
has-patch needs-testing |
-------------------------------------------------+-------------------------
Comment (by ironprogrammer):
LGTM! 👍🏻 Thanks for the PR!
== Test Report
Patch tested: https://github.com/WordPress/wordpress-develop/pull/5691
=== Environment
- Hardware: MacBook Pro Apple M1 Pro
- OS: macOS 13.6.2
- Browser: Safari 17.1, Google Chrome 119.0.6045.199
- Server: nginx/1.25.3
- PHP: 8.3.0
- WordPress: 6.5-alpha-56966-src
- Theme: twentytwentyfour v1.0
=== Actual Results
- ✅ The default "W" icon is replaced with the newly set site icon after
the page is refreshed.
- ✅ If the site icon has alternatively been set via "Site Icon settings"
(`/wp-admin/customize.php?autofocus[section]=title_tagline`) or a previous
(classic theme) Customizer "Site Identity" update, re-enabling the "Use as
site icon" on the Site Icon block will replace the previously set icon
with the new icon after the page is refreshed.
=== Additional Notes
- In [comment:5 test step 2], make sure that the Site Icon block's "Use as
site icon" setting is enabled.
- A page refresh (or navigation out and back into the site editor) is
required to display the updated site icon.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/59935#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list