[wp-trac] [WordPress Trac] #55969: The function set_transient should have the autoload argument
WordPress Trac
noreply at wordpress.org
Sun Nov 26 23:10:03 UTC 2023
#55969: The function set_transient should have the autoload argument
--------------------------------+------------------------------
Reporter: giuse | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Options, Meta APIs | Version: 6.0
Severity: normal | Resolution:
Keywords: needs-patch | Focuses: performance
--------------------------------+------------------------------
Comment (by galbaras):
Replying to [comment:4 giuse]:
> Do you see any downsides in modifying the function with something like
this?
I don't think there is a (significant) downside.
Also, your code refers to `$ccustom_autoload_is_valid`, which should be
`$custom_autoload_is_valid`.
Replying to [comment:5 desrosj]:
> @giuse if you could, please attach your
[https://make.wordpress.org/core/handbook/best-practices/writing-patches/
suggested changes in the form of a patch] or a
[https://make.wordpress.org/core/handbook/contribute/git/github-pull-
requests-for-code-review/ pull request on GitHub]. It's very difficult to
see what is being changed from a full snippet.
Since the suggested code is already in this ticket, can you help with
this? Personally, I wouldn't know what to do.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/55969#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list