[wp-trac] [WordPress Trac] #59906: Navigation link block variations - Maybe backport into core
WordPress Trac
noreply at wordpress.org
Tue Nov 14 08:06:22 UTC 2023
#59906: Navigation link block variations - Maybe backport into core
-------------------------+-----------------------------
Reporter: gaambo | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Editor | Version:
Severity: normal | Keywords:
Focuses: |
-------------------------+-----------------------------
In [https://github.com/WordPress/gutenberg/pull/54801 Gutenberg PR 54801]
some functions were added to the navigation link blocks php file to
register variations for all post types/taxonomies.
@andraganescu asked me to open a ticket here, to check if those changes
would need to be manually backported and moved somewhere else in core?
As I understand, if those should just stay in the blocks `index.php` file,
they will get merged into core with the gutenberg packages update. But
since those are a few functions and the blocks php file is getting longer,
it may make sense to put them somewhere else?
Also there's another [https://github.com/WordPress/gutenberg/pull/56100
PR] which fixes some things in this functionality and also
[https://github.com/WordPress/gutenberg/pull/56080 a PR for the post-terms
block] which handles the same thing.
So there are two blocks which hook into
`registered_post_type`/`registered_taxonoomy`. A point could be made, to
combine those two. But I think, having them in the blocks directly, is
more clear.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/59906>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list