[wp-trac] [WordPress Trac] #58827: Publish the Patterns page in the Site Editor to all non-block themes
WordPress Trac
noreply at wordpress.org
Fri Nov 10 03:32:40 UTC 2023
#58827: Publish the Patterns page in the Site Editor to all non-block themes
-------------------------------------------------+-------------------------
Reporter: wildworks | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 6.5
Component: Editor | Version:
Severity: normal | Resolution:
Keywords: has-patch has-testing-info needs- | Focuses:
testing |
-------------------------------------------------+-------------------------
Comment (by rajinsharwar):
Hi @wildworks, I tested your patch against the trunk as of today. LGTM on
my tests, but there is one thing that I found.
So, suppose I am using a theme that doesn't have the "block-template-
parts", for example, Astra. I activated that theme, and in the
functions.php, I added: add_theme_support( 'block-template-parts' );
Then, the Template parts menu option was visible. I clicked on that, and
it took many seconds to load, and after that the die message: "The theme
you are currently using is not compatible with the Site Editor." was
shown. After I returned back, I found that there was no more the "template
Parts" option on the menu and the code of "add_theme_support( 'block-
template-parts' );" was removed from my theme's functions.php.
I am not really sure if this behavior is good, as modifying the theme
files without notice isn't something the core should do.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/58827#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list