[wp-trac] [WordPress Trac] #58405: Use is_block_theme in WP_Theme

[WordPress Trac]

#58405: Use is_block_theme in WP_Theme
-------------------------------------------------+-------------------------
 Reporter:  spacedmonkey                         |       Owner:  (none)
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Themes                               |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  good-first-bug has-patch changes-    |     Focuses:
  requested                                      |
-------------------------------------------------+-------------------------
Changes (by mukesh27):

 * keywords:  good-first-bug has-patch => good-first-bug has-patch changes-
     requested


Old description:

> In line of 366 / 367 of the `WP_Theme` class, there are manual calls to
> if files exists. However, in this context we can use the method
> `is_block_theme`. This remove repeated code and hit an existing cache.

New description:

 Hi there!

 Thank you both for the PR and patch.

 @nihar007, in your patch, did you take a different approach than PR 4514
 ([https://github.com/WordPress/wordpress-develop/pull/4514])? Instead of
 adding a duplicate patch, please review the PR and provide your feedback
 on it. Thank you!

--

Comment:

 Hi there!

 Thanks for PR/Patch both of you.

 @nihar007 in your patch do you use different approach then
 [https://github.com/WordPress/wordpress-develop/pull/4514 PR 4514]?
 Instead of adding duplicate patch try you can check review the PR and
 share your feedback on it. Thanks!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58405#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform