[wp-trac] [WordPress Trac] #57952: Able to delete multiple users with the Change button - STRANGE

[WordPress Trac]

#57952: Able to delete multiple users with the Change button - STRANGE
-----------------------------------------------+---------------------------
 Reporter:  haritpanchal                       |       Owner:
                                               |  SergeyBiryukov
     Type:  defect (bug)                       |      Status:  closed
 Priority:  normal                             |   Milestone:  6.3
Component:  Users                              |     Version:
 Severity:  major                              |  Resolution:  fixed
 Keywords:  has-patch has-testing-info commit  |     Focuses:
                                               |  administration
-----------------------------------------------+---------------------------
Changes (by SergeyBiryukov):

 * owner:  (none) => SergeyBiryukov
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"55864" 55864]:
 {{{
 #!CommitTicketReference repository="" revision="55864"
 Users: Make sure bulk actions are only executed with the Apply button, not
 Change.

 The Change button is supposed to perform the “Change role to...” action
 only, but could unintentionally be used for other bulk actions if the role
 was not selected.

 This commit removes an extra check and ensures the correct error message
 is displayed in that case:

  Sorry, you are not allowed to give users that role.

 Follow-up to [6990], [8691], [9028], [15576], [15642], [34636], [49944].

 Props haritpanchal, costdev, ankit-k-gupta, SergeyBiryukov.
 Fixes #57952.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57952#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform