[wp-trac] [WordPress Trac] #57913: Attachment pages need to have an "on" toggle

[WordPress Trac]

#57913: Attachment pages need to have an "on" toggle
-------------------------+------------------------------
 Reporter:  joostdevalk  |       Owner:  (none)
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Media        |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  2nd-opinion  |     Focuses:
-------------------------+------------------------------
Changes (by azaozz):

 * keywords:  has-patch => 2nd-opinion


Comment:

 Replying to [comment:6 audrasjb]:
 > Would this change redirect all kind of attachments? Would it force
 redirection over all the `single-attachment-{slug}.php` and the various
 `{MIME-type}.php` templates (like `pdf.php`, `video.php`, `text-
 plain.php`, etc)?

 All very good questions. Seems leaving the decision to the theme would be
 best. I.e. the theme may decide to include a template for specific type of
 attachments but not for others, etc. Also seems `single-
 attachment-{slug}.php` may need to be an exception? This should probably
 be reflected when making a patch.

 That said, looking at https://github.com/WordPress/wordpress-
 develop/pull/4233 don't think having a checkbox anywhere in WP is a good
 idea and also don't think storing an option to (globally) turn visibility
 of attachment pages on/off is good either. As mentioned above seems this
 should be an `add_theme_support()` thing. Will comment on the PR too.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57913#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform