[wp-trac] [WordPress Trac] #58433: WP version in Etag header in load-styles.php file

[WordPress Trac]

#58433: WP version in Etag header in load-styles.php file
-------------------------------------+------------------------------
 Reporter:  dav4                     |       Owner:  (none)
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  General                  |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+------------------------------
Changes (by ironprogrammer):

 * keywords:  needs-testing-info has-patch needs-testing => has-patch needs-
     testing


Comment:

 Thanks, @peterwilsoncc! In running through these steps, it appears the
 current Etags emitted by `load-scripts.php` and `load-styles.php` are not
 [https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/ETag#syntax
 double-quoted], which prevents them from being emitted (at least in
 Nginx).

 The tweak in [attachment:58433-poc-2.diff] should emit the tag as expected
 (see the [https://core.trac.wordpress.org/browser/trunk/src/wp-includes
 /ms-files.php#L58 Etag header in `ms-files.php` for comparison]).

 The steps provided are great 👍🏻 The only addition would be to ensure
 that your environment has `define( 'SCRIPT_DEBUG', false );`, as that
 allows both `load-scripts.php` and `load-styles.php` to be used (or just
 apply the patch to a vanilla WP install).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58433#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform