[wp-trac] [WordPress Trac] #58946: Specificity of _admin_bar_bump_cb() echo and violation of MVC by that function

WordPress Trac noreply at wordpress.org
Mon Jul 31 23:36:44 UTC 2023


#58946: Specificity of _admin_bar_bump_cb() echo and violation of MVC by that
function
----------------------------+------------------------------
 Reporter:  letraceursnork  |       Owner:  (none)
     Type:  enhancement     |      Status:  new
 Priority:  normal          |   Milestone:  Awaiting Review
Component:  Toolbar         |     Version:  3.1
 Severity:  minor           |  Resolution:
 Keywords:                  |     Focuses:
----------------------------+------------------------------
Changes (by sabernhardt):

 * keywords:  needs-patch =>
 * version:  6.2.2 => 3.1
 * component:  General => Toolbar


Comment:

 Hi and thanks for the ticket!

 The toolbar has fixed (or absolute) positioning, so a top margin can
 prevent it from covering front-end content.

 History:
 - #15592 created the callback function
 - #15851 added the `!important` "nuclear option"
 - #16222 switched padding to margin
 - #25858 set a `782px` breakpoint
 - #52623 created the CSS custom property, without using it in the callback
 (#54032 could change that, but I would prefer to wait a bit longer)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58946#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list