[wp-trac] [WordPress Trac] #57854: Twenty Twenty-One: Pull Quote block font-size issue
WordPress Trac
noreply at wordpress.org
Wed Jul 5 14:18:27 UTC 2023
#57854: Twenty Twenty-One: Pull Quote block font-size issue
-------------------------------------+---------------------
Reporter: nidhidhandhukiya | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 6.3
Component: Bundled Theme | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing | Focuses:
-------------------------------------+---------------------
Comment (by varjodesigns):
Replying to [comment:7 poena]:
> Thank you for the pull request.
>
> I have tested the changes to the SCSS files but I rebuilt the CSS
locally using the npm commands. All the block's typography settings are
working for the paragraph.
>
>
> I see that not all typography options work with the cite.
> I am torn wether or not the font size option should be applied to the
cite, but I think it can be unexpected and confusing for users that only
some of the options work.
> What do you think?
----
Thanks for testing it out, and for the insightful comment on the cite
block supports!
If the typography settings cascade to the cite, there may be difficulty in
maintaining the visual hierarchy of the cite in relation to the paragraph.
Say you indeed chose a very large text size, and that resulted in both the
cite and the paragraph assuming same size. This could be resolved by
applying a multiplier for the cite size, but that might be unexpected to
those users of the theme who may have customized this block for their
sites, and might be less intuitive to overwrite per site.
I would therefore be inclined to leave the cite styling as it is. The cite
in my personal opinion is mainly a helper label for the quote, while
paragraph carries the main visual interest of the component. Unless the
block is later parted so that both parts have their own supports, with
maybe inheritance from main block, I would go with having the styles
cascade to paragraph, whilst leaving the less visual cite component to
work with the solid defaults it has.
And as for partially implementing typography supports, I feel that might
indeed be more confusing than having them not apply to the cite at all.
Ideally I think these two should have their own block supports in their
future, so you could overwrite unwanted inheritance and achieve the look
you really want to.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/57854#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list