[wp-trac] [WordPress Trac] #58672: Font asset files not loading within iframed editor

WordPress Trac noreply at wordpress.org
Tue Jul 4 16:40:33 UTC 2023


#58672: Font asset files not loading within iframed editor
-------------------------------------------------+-------------------------
 Reporter:  ironprogrammer                       |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  6.3
Component:  Editor                               |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-testing-info has-      |     Focuses:
  screenshots gutenberg-merge needs-unit-tests   |
-------------------------------------------------+-------------------------

Comment (by antonvlasenko):

 In my opinion, this PR may not necessarily need unit tests for the
 following reasons:
 1. `$fn_compile_src` is not a public API, so it would be problematic to
 write unit tests for that function; `$fn_compile_src` is not accessible
 from outside (it's an anonymous function);
 2. The code changes made in this PR are considered "harmless." The
 suggested PR simply removes the code that removes the http* prefix. I am
 having difficulty understanding what exactly a unit test for this should
 cover.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58672#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list