[wp-trac] [WordPress Trac] #56975: Replace the internal `WP_Theme_JSON_Resolver::theme_has_support()` with a public function
WordPress Trac
noreply at wordpress.org
Sun Jan 22 11:45:09 UTC 2023
#56975: Replace the internal `WP_Theme_JSON_Resolver::theme_has_support()` with a
public function
-------------------------------------------------+-------------------------
Reporter: oandregal | Owner:
| hellofromTonya
Type: enhancement | Status: reopened
Priority: normal | Milestone: 6.2
Component: Themes | Version:
Severity: normal | Resolution:
Keywords: dev-feedback gutenberg-merge has- | Focuses:
patch has-unit-tests has-testing-info | performance
-------------------------------------------------+-------------------------
Comment (by oandregal):
> We can create a new PR where we introduce a static variable, and keep
the WP cache API (including the non-persistent cache group) out of it. For
the other related tickets where we have been considering using the API, we
need to separately consider and measure whether it's worth it.
I found myself in a layover with a half an hour to kill and re-checked the
conversations in this ticket. Prepared https://github.com/WordPress
/wordpress-develop/pull/3887 I won't be fully available until Wednesday,
so feel free to address any feedback and merge.
Note I didn't remove the existing non-persistent group or the function
wp_clean_theme_json_cache, as it's going to be necessary for the
wp_get_global_settings anyway. If it is not, it can be removed in a
separate PR as well.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/56975#comment:77>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list