[wp-trac] [WordPress Trac] #57386: Add filter to WP_Upgrader::install_package for copy_dir()

WordPress Trac noreply at wordpress.org
Wed Jan 18 18:31:58 UTC 2023


#57386: Add filter to WP_Upgrader::install_package for copy_dir()
------------------------------------+--------------------------
 Reporter:  afragen                 |       Owner:  (none)
     Type:  feature request         |      Status:  reopened
 Priority:  normal                  |   Milestone:  6.2
Component:  Upgrade/Install         |     Version:  trunk
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  performance
------------------------------------+--------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:38 costdev]:
 > This appears to confirm my findings that `rename()` itself is not an
 issue with VirtualBox

 Right, I believe that means `move_dir()` can be safely used in
 `WP_Upgrader::install_package()`, and both #57375 and this ticket are now
 unblocked. No workaround is needed for VirtualBox at this time, as the
 problematic sequence is never used in normal updates, only in the current
 implementation of rollbacks, which is out of scope for this ticket and can
 be further investigated in #51857.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57386#comment:39>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list